SatelliteQE
/
nailgun
/
482
/
2
97%
master: 97%
master: 97%
|
Ran
|
Files
6
|
Run time
0s
|
Badge
Embed ▾
README BADGES
|
coverage: 97.163%. Remained the same
push
travis-ci
Ichimonji10Release version 0.22.0 This release fixes a major bug present in version 0.21.0. Specifically, this release fixes a bug introduced by 3857d0180, entitled "Make class ServerConfig set a default version". The ServerConfig class will no longer set a default version if none is provided. The ServerConfig class now has the same behaviour it has had for some time: > When a `ServerConfig` object is created, only the 'url' argument is required. > All other arguments are optional. […] > > >>> from nailgun.config import ServerConfig > >>> hasattr(ServerConfig('some url'), 'version') > False This does lead to some awkward version comparisons: > This leads to idioms like the following in module `nailgun.entities`: > > if _get_version(self._server_config) < Version('6.1'): > # do something However, this approach is the most semantically correct approach available. In addition, in this case it seems better to have a single slightly awkward idiom for version comparisons than to have two separate but similar idioms for version comparisons.
1404 of 1445 relevant lines covered (97.16%)
0.97 hits per line
