1
57%
master: 53%

Ran 13 Aug 2015 12:52PM UTC

Files 12

Run time 0s

Badge

Embed ▾

Committed 13 Aug 2015 12:50PM UTC coverage: 56.672% (+3.5%) from 53.213%

Job # 415.1

Build Type

push

travis-ci

Committed by

ashb

Commit Message

Fix error in creating salt tar when you project has a file in ./salt/_grains/

The problem was the shutil.copytree expects the target directory to not
exists, and if it already exists then will raise an OSError. This could
happen because we first copy the project's ./salt dir to the tmp dir
(which in this case had a ./salt/_grains/neighbours.py), and then we try
to copy the contrib/srv/salt/_grains/ dir which fails because the
previous step created that folder already.

The best solution I can found (as mentioned in
http://stackoverflow.com/a/12687372/439189) is to copy the
implementation of copytree from the shutil module and put a guard around
the the makedir

Coverage Stats

344 of 607 relevant lines covered (56.67%)

0.57 hits per line

ministryofjustice / bootstrap-salt / 415 / 1
57%
master: 53%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 415.1

ministryofjustice / bootstrap-salt / 415 / 1 57% master: 53%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 415.1

ministryofjustice / bootstrap-salt / 415 / 1
57%
master: 53%

README BADGES
x