1
63%
master: 63%

Ran 24 Feb 2021 11:36AM UTC

Files 65

Run time 10s

Badge

Embed ▾

Committed 24 Feb 2021 11:32AM UTC coverage: 57.186% (-0.2%) from 57.42%

Job # 11214.1

Build Type

push

travis-ci

Committed by

SomberNight

Commit Message

synchronizer: better handle history-status mismatch

When receiving the history of an address, the client behaved unexpectedly
if either of two checks failed.
The client checked that the txids in the history are unique, and that the
history matches the previously announced status. If either failed, it
would just log a line and do nothing. Importantly, the synchronizer could
even consider itself is_up_to_date, i.e. the GUI could show the wallet is
synced.

This is now changed such that:
- if the txid uniqueness test fails, we simply disconnect
- if the history is not consistent with previously announced status,
  we wait a bit, make sure is_up_to_date is False in the meantime,
  and then potentially disconnect
See rationale for these in the comments.

related: https://github.com/spesmilo/electrum/issues/7058#issuecomment-783613084

Run Details

14435 of 25242 relevant lines covered (57.19%)

0.57 hits per line

spesmilo / electrum / 11214 / 1
63%
master: 63%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 11214.1

spesmilo / electrum / 11214 / 1 63% master: 63%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 11214.1

spesmilo / electrum / 11214 / 1
63%
master: 63%

README BADGES
x