3
85%
master: 85%

Ran 19 Jul 2015 05:15AM UTC

Files 38

Run time 2s

Badge

Embed ▾

Committed 19 Jul 2015 05:11AM UTC coverage: 84.932%. First build

Job # COVERAGE="--disable-valgrind --enable-gcov"

Build Type

push

travis-ci

Committed by

dtolnay

Commit Message

Resolve shift/reduce conflict of 'def' vs '|'

This was an important conflict. In the following expression:

    def a: 0; . | a

Bison needs to decide between these two equally valid
parses:

    (def a: 0; .) | a
    def a: 0; (. | a)

For jq we want the second one, because the first results in
"a/0 is not defined". In the current parser the first parse
is a reduce and the second parse is a shift. Since Bison
prefers to shift in shift/reduce conflicts, we accidentally
got the correct behavior.

This commit adds a precedence level FUNCDEF which is lower
precedence than '|', meaning we explicitly choose the
correct parse.

Of course many unit tests already cover this case, but I
added one specifically for it.

Run Details

4746 of 5588 relevant lines covered (84.93%)

363502.54 hits per line

dtolnay / jq / 93 / 3
85%
master: 85%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 93.3 (COVERAGE="--disable-valgrind --enable-gcov")

dtolnay / jq / 93 / 3 85% master: 85%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 93.3 (COVERAGE="--disable-valgrind --enable-gcov")

dtolnay / jq / 93 / 3
85%
master: 85%

README BADGES
x