OSGeo / PROJ / 4063 / 1
86%
master: 87%

LAST BUILD BRANCH: rouault-patch-3
DEFAULT BRANCH: master
Ran
Files 238
Run time 22s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 86.503% (+0.02%) from 86.483%
BUILD_NAME=linux_gcc DETAILS="linux, gcc-4.8" CC=gcc-4.8 CXX=g++-4.8

push

travis-ci-com

Even Rouault 
Use same arguments to printf format string for both radians and degrees in output by cct (#2453)

Currently the output of the cct utility is different between radians
and degrees (as expected by cct), because of a bug in cct:

$ printf "1 2\n" | cct -z 0 -t 0 +proj=pipeline +step +proj=unitconvert +xy_in=deg +xy_out=rad
  1.0000000000    2.0000000000        0.0000        0.0000

$ printf "1 2\n" | cct -z 0 -t 0 +proj=pipeline +step +proj=unitconvert +xy_in=deg +xy_out=deg
       1.0000         2.0000        0.0000        0.0000

The arguments to the printf format string are as follows:

 * radians: width 14, precision 10
 * degrees: width 13, precision  4 (this is by mistake. bug!)

After the suggested fix has been applied, output will be the same for
both radians and degrees:

$ printf "1 2\n" | cct -z 0 -t 0 +proj=pipeline +step +proj=unitconvert +xy_in=deg +xy_out=rad
  1.0000000000    2.0000000000        0.0000        0.0000

$ printf "1 2\n" | cct -z 0 -t 0 +proj=pipeline +step +proj=unitconvert +xy_in=deg +xy_out=deg
  1.0000000000    2.0000000000        0.0000        0.0000

The cause of the bug is that cct does test if it "has radians to output",
but "neglects" to test if it "has degrees to output", resulting in using
different arguments to the printf format string in the latter case.

The fix makes cct test if it "has either radians or degrees to output".

41138 of 47557 relevant lines covered (86.5%)

41243.99 hits per line

Source Files on job 4063.1 (BUILD_NAME=linux_gcc DETAILS="linux, gcc-4.8" CC=gcc-4.8 CXX=g++-4.8)