1
100%
master: 100%

Ran 25 Nov 2020 10:00AM UTC

Files 13

Run time 2s

Badge

Embed ▾

Committed 25 Nov 2020 09:56AM UTC coverage: 100.0%. Remained the same

Job # 986.1

Build Type

push

travis-ci-com

Committed by

mgedmin

Commit Message

Fix SIGABRT in BTree code

The way iteration works is, a BTree first defines the iteration range as
a pair (lowbucket, lowindex), (highbucket, highindex), and then follows
the chain of buckets, stopping when it reaches highbucket.

You can iterate by specifying min/max bounds (which needs the binary
tree search to find lowbucket/highbucket) or the entire BTree (the case
we're interested in).

Finding lowbucket is easy: BTree has a reference to firstbucket.

There are two ways of finding highbucket: you can follow the nextbucket
chain from firstbucket until you hit NULL (O(N)), or you can walk
internal tree nodes by picking the rightmost child in each (O(log N)),
which is what the code does.

zodbbrowser was restoring all buckets, but not touching internal tree
nodes, so if you cleared out the tree completely and then tried to look
into an older state, the current OOBTree would have a NULL highbucket,
and we'd trigger this assertion.

Fixes #33.

Run Details

1414 of 1414 relevant lines covered (100.0%)

1.0 hits per line

mgedmin / zodbbrowser / 986 / 1
100%
master: 100%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 986.1

mgedmin / zodbbrowser / 986 / 1 100% master: 100%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 986.1

mgedmin / zodbbrowser / 986 / 1
100%
master: 100%

README BADGES
x