1
61%
master: 61%

Ran 17 Nov 2020 10:39PM UTC

Files 39

Run time 9s

Badge

Embed ▾

Committed 17 Nov 2020 08:33PM UTC coverage: 62.536% (+0.04%) from 62.496%

Job # GH_TOKEN=[secure] GH_REPO=github.com/locomotivemtl/charcoal-property.git

Build Type

push

travis-ci

Committed by

mcaskill

Commit Message

Fix storing and parsing of l10n/allowNull values

Fixes a conflict on properties that are multilingual (`l10n`) and nullable (`allowNull`) where a localized field (for example `name_fr`) would convert an empty string to `null`.

Upon loading that data from source, the property would ignore the localized `null` field and return only the non-null field. A translatable property should be returned as a whole.

Changed:
- Method `StorablePropertyTrait::storageVal()` to stringify `Translation` objects earlier.
- Method `StorablePropertyTrait::storageVal()` to return empty string instead of `null` for multilingual/nullable property value (specifically, it's language field).
- Method `StorablePropertyTrait::parseFromFlatData()` to assign an empty string for null/missing localizations.

Run Details

1948 of 3115 relevant lines covered (62.54%)

4.57 hits per line

locomotivemtl / charcoal-property / 441 / 1
61%
master: 61%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 441.1 (GH_TOKEN=[secure] GH_REPO=github.com/locomotivemtl/charcoal-property.git)

locomotivemtl / charcoal-property / 441 / 1 61% master: 61%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 441.1 (GH_TOKEN=[secure] GH_REPO=github.com/locomotivemtl/charcoal-property.git)

locomotivemtl / charcoal-property / 441 / 1
61%
master: 61%

README BADGES
x