5
39%
master: 39%

Ran 09 Nov 2020 11:09PM UTC

Files 6

Run time 1s

Badge

Embed ▾

Committed 09 Nov 2020 11:08PM UTC coverage: 38.511% (+7.0%) from 31.476%

Job # AMP_DEBUG=true

Build Type

push

travis-ci-com

Committed by

web-flow

Commit Message

Connection pool pop() or push() should modify to release idle connection. (#3)

In source code, the pop() method invoke idle->shift() to get top of pool list connection to use, and push return it back to the bottom of list.

In timeoutWatcher first check bottom of the list connection, if not idle will do nothing.

If connection pool has expanded at peak, when the traffic drops back to a low peak, as long as there is one query in each idle time, all connection will never released!!! but only one or two connection is enough now.

So I think idle->push() should change to idle->unshift(), then real idle connection in bottom will be released in time, or timeoutWatcher check top, and pop() change to real idle->pop().

See also https://github.com/amphp/mysql/issues/99

Run Details

119 of 309 relevant lines covered (38.51%)

0.67 hits per line

amphp / sql-common / 32 / 5
39%
master: 39%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 32.5 (AMP_DEBUG=true)

amphp / sql-common / 32 / 5 39% master: 39%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 32.5 (AMP_DEBUG=true)

amphp / sql-common / 32 / 5
39%
master: 39%

README BADGES
x