1
58%
master: 97%

Ran 06 Jul 2015 05:10PM UTC

Files 66

Run time 3s

Badge

Embed ▾

Committed 06 Jul 2015 05:03PM UTC coverage: 58.471%. Remained the same

Job # 6873.1

Build Type

push

travis-ci

Committed by

nickstenning

Commit Message

Only make one search query per frame on page load

Previously, when loading Hypothesis into a page, the client would make
one search request for each and every URI found on the page, including
those found by the document metadata scanners (in the Annotator
"Document" and "PDF" plugins.)

This is wasteful of network bandwidth, and moreover should not be
necessary in most cases due to the ability to expand to equivalent URIs
on the server side.

The component responsible for coordinating communication across page
frames is the "crossframe" service. This services maintains a registry
of page frames (previously called "providers") and their associated
metadata. This commit reduces the metadata stored to simply the page
URL, or in the case of PDF documents, the fingerprint URN.

It's worth noting that this *does* change behaviour in one important
way: if a page contains document equivalence data that we've never seen
before, and one of the alternate URIs has already been annotated, then
this change will mean we do not load annotations until that page itself
has been annotated (and thus the document equivalence data updated). I
am assuming that this is an extreme edge case.

Run Details

1698 of 2904 relevant lines covered (58.47%)

0.58 hits per line

hypothesis / h / 6873 / 1
58%
master: 97%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 6873.1

hypothesis / h / 6873 / 1 58% master: 97%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 6873.1

hypothesis / h / 6873 / 1
58%
master: 97%

README BADGES
x