gnosis / dex-services / 5307 / 3

31%

master: 31%

push

travis-pro

Add flag to ignore external price sources (#1477)

On rinkeby we occasionally see negative utility solutions which lead to a subtraction overflow (cf. https://github.com/gnosis/dex-solver/issues/325)

The assumption is that external price estimates are too far off the weird prices we might see on an economically not incentivised test net like rinkeby. Therefore the plan is to ignore these external source on rinkeby going forward.

### Test Plan

```bash
cargo run --bin driver -- --node-url https://xdai.poanetwork.dev  --rpc-timeout 60000 --orderbook-file target/orderbook_xdai.bin --private-key c87509a1cc0241e5e4a9ec0a0f44dc0d3 --solver-type opensolver --native-token-id 0 --log-filter "warn,driver=info,services_core=info,services_core::price_estimation=debg" --ignore-external-price-source true
```

See no log entries coming from `price_estimation::clients::generic_client`

13079 of 53506 branches covered (24.44%)

Branch coverage included in aggregate %.

3477 of 5442 relevant lines covered (63.89%)

43505.44 hits per line