1
78%
main: 78%

Ran 19 Oct 2020 10:57PM UTC

Files 687

Run time 3min

Badge

Embed ▾

Committed 19 Oct 2020 10:57PM UTC coverage: 78.299% (-0.01%) from 78.31%

Job # 176150.1

Build Type

push

CI-PR build

Committed by GitHub

Commit Message

Adds check to TranscriptLoggerMiddleware doesn't log continue conversation event activities (#4797)

* Adds check to TranscriptLoggerMiddleware doesn't log contine conversation event activities.

Changes include:
- Added check in TranscriptLoggerMiddleware to filter incoming ContinueConversation events.
- Introduced EventActivityNames class with constant strings for ContinueConversation so we don't have those strings hardcoded.
- Added also CreateConversation to the EventActivityNames helper (not related to this issue but saw it and decided to add it since it is better to have constants).
- Refactored ConversationReferenceEx to use the new constant (and use more straightforward code to create the event).
- Added tests for new logic in TranscriptLoggerMiddleware.
- Updated Skills testing projects to use the new constant

* Renamed EventActivityNames to ActivityEventNames

* Updated a couple of files that I missed after the rename.

Run Details

17027 of 21746 relevant lines covered (78.3%)

0.78 hits per line

microsoft / botbuilder-dotnet / 176150 / 1
78%
main: 78%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 176150.1

microsoft / botbuilder-dotnet / 176150 / 1 78% main: 78%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 176150.1

microsoft / botbuilder-dotnet / 176150 / 1
78%
main: 78%

README BADGES
x