1
44%
master: 44%

Ran 19 Oct 2020 02:23PM UTC

Files 31

Run time 10s

Badge

Embed ▾

Committed 19 Oct 2020 02:18PM UTC coverage: 29.653% (-0.08%) from 29.737%

Job # 3299.1

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

Lookup function installation (#1171)

* Lookup function installation

Due to reusing a previous database connection without closing it, lookup
function installation process was skipping the first database in the
list, installing twice into postgres db instead. To prevent that, make
internal initDbConnWithName to overwrite a connection object, and return
the same object only from initDbConn, which is sort of public interface.

Another solution for this would be to modify initDbConnWithName to
return a connection object and then generate one temporary connection
for each db. It sound feasible but after one attempt it seems it
requires a bit more changes around (init, close connections) and
doesn't bring anything significantly better on the table. In case if
some future changes will prove this wrong, do not hesitate to refactor.

Change retry strategy to more insistive one, namely:

* retry on the next sync even if we failed to process one database and
install pooler appliance.

* perform the whole installation unconditionally on update, since the
list of target databases could be changed.

And for the sake of making it even more robust, also log the case when
operator decides to skip installation.

Extend connection pooler e2e test with verification that all dbs have
required schema installed.

Coverage Stats

2871 of 9682 relevant lines covered (29.65%)

2.19 hits per line

zalando / postgres-operator / 3299 / 1
44%
master: 44%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 3299.1

zalando / postgres-operator / 3299 / 1 44% master: 44%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 3299.1

zalando / postgres-operator / 3299 / 1
44%
master: 44%

README BADGES
x