npm / arborist / #304 / 1

push

Respect gypfile:false flag in package.json

This does a couple of things:

1. Explicitly add a flag in _addToBuildSet to indicate that we've
   already checked this node.  This _should_ be unnecessary, but it's
   possible that we have no script and still need to check for a gypfile
   when we have old metadata, so this addresses the edge case there, and
   makes the logic a little clearer.
2. Use the defaultGypInstallScript from the @npmcli/node-gyp package,
   rather than a hard-coded string.
3. Handle cases where there are bins and also a default node-gyp script.

PR-URL: https://github.com/npm/arborist/pull/151
Credit: @isaacs
Close: #151
Reviewed-by: @nlf

2272 of 2272 branches covered (100.0%)

Branch coverage included in aggregate %.

3275 of 3275 relevant lines covered (100.0%)

353.65 hits per line