6
84%
master: 84%

Ran 02 Oct 2020 02:12PM UTC

Files 25

Run time 3s

Badge

Embed ▾

Committed 02 Oct 2020 02:05PM UTC coverage: 83.103%. Remained the same

Job # OS=fedora OS_VERSION=30 PYTHON_VERSION=3 ENGINE=docker

Build Type

push

travis-ci

Committed by

MartinBasti

Commit Message

HttpStream: fix close method

`.close()` is called from `__del__` and because this happend during
garbage collecting nothing is guaranted [1] and it results into following
traceback printed directly to stderr because it happened in GC context:
```
Traceback (most recent call last):
  File "/home/mbasti/repos-upstream/osbs-client/osbs/http.py", line 221, in __del__
    self.close()
  File "/home/mbasti/repos-upstream/osbs-client/osbs/http.py", line 214, in close
    if not self.closed:
AttributeError: 'HttpStream' object has no attribute 'closed'
```

Using getattr instead to avoid traceback.

TLDR: use context managers if you want to be sure that connection is closed
properly.

[1] https://docs.python.org/3/reference/datamodel.html#object.__del__

Signed-off-by: Martin Bašti <mbasti@redhat.com>

Run Details

3546 of 4267 relevant lines covered (83.1%)

0.83 hits per line

containerbuildsystem / osbs-client / 5172 / 6
84%
master: 84%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 5172.6 (OS=fedora OS_VERSION=30 PYTHON_VERSION=3 ENGINE=docker)

containerbuildsystem / osbs-client / 5172 / 6 84% master: 84%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 5172.6 (OS=fedora OS_VERSION=30 PYTHON_VERSION=3 ENGINE=docker)

containerbuildsystem / osbs-client / 5172 / 6
84%
master: 84%

README BADGES
x