zopefoundation / Zope / 4179 / 4

81%

master: 82%

push

travis-ci

Fix export of files with non-latin-1 compatible names (#893)

* Fix export of files with non-latin-1 compatible names

With Zope 4 unicode characters for ids are allowed.

The `zexp` export was not updated yet.

This has been fixed now.

closes #890

modified:   CHANGES.rst
modified:   src/OFS/ObjectManager.py
modified:   src/Testing/ZopeTestCase/testZODBCompat.py
new file:   src/ZPublisher/http_header_utils.py
new file:   src/ZPublisher/tests/test_http_header_utils.py

* Fix white space

modified:   src/ZPublisher/tests/test_http_header_utils.py

* Implement custom code for header creation

The ZPL does not allow to vendor third party code except the original
author would sign the contributor agreement.

As this is not realistic in this case, a custom solution was implemented
to handle non-latin-1 compatible headers.

modified:   src/OFS/ObjectManager.py
modified:   src/ZPublisher/http_header_utils.py
modified:   src/ZPublisher/tests/test_http_header_utils.py

* Update year

modified:   src/ZPublisher/tests/test_http_header_utils.py

* Use `us-ascii` encoding for the content-disposition header

modified:   src/Testing/ZopeTestCase/testZODBCompat.py
modified:   src/ZPublisher/http_header_utils.py
modified:   src/ZPublisher/tests/test_http_header_utils.py

* Move `make_content_disposition` into `HTTPResponse` module

modified:   src/OFS/ObjectManager.py
modified:   src/ZPublisher/HTTPResponse.py
deleted:    src/ZPublisher/http_header_utils.py
modified:   src/ZPublisher/tests/testHTTPResponse.py
deleted:    src/ZPublisher/tests/test_http_header_utils.py

Co-authored-by: Jens Vagelpohl <jens@netz.ooo>

4131 of 6907 branches covered (59.81%)

Branch coverage included in aggregate %.

25908 of 30709 relevant lines covered (84.37%)

0.84 hits per line