kubevirt / hyperconverged-cluster-operator / 3787 / 1
70%
main: 76%

LAST BUILD BRANCH: release-1.16
DEFAULT BRANCH: main
Ran
Files 3
Run time 1s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 80.722%. Remained the same
3787.1

push

travis-ci

web-flow 
add error handling to hack/build-manifest.sh (#828)

* add error handling to hack/build-manifest.sh

`set -e` does not stop the process if the error is happened within a command substitution. This is why the [`hack/build-manifest.sh`] script didn't fail in some cases, e.g. when an image was missing in the remote registry.

This PR added error handling to the script:
* Added `trap` command and the `catch` method
* command substitution inside string building didn't catch by the trap. This lines were split to make sure the trap catches any error. For example:
```bash
A_VARIABLE="Text text${VAR1}/$(failed command)"
```
was split to something like:
```bash
A_TEMP_VAR="$(failed command)"
A_VARIABLE="Text text${VAR1}/${A_TEMP_VAR}"
```
* Single line local variables with command substitution were not caught by the trap, and was also split. For example:
```bash
function foo() {
  ...
  local a_variable="$(failed command)"
  ...
```
was split to something like:
```bash
function foo() {
  ...
  local a_variable
  a_variable="$(failed command)"
  ...
```
* Add simple versifcation to the operator CSV files, by greping for their `image:` line. This check both that the file is not empty and the image makes some sense

Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>

* csv-merger will now panic if one of the CSVs is empty

Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>

1319 of 1634 relevant lines covered (80.72%)

39.57 hits per line

Source Files on job 3787.1