4
100%
master: 100%

Ran 18 Sep 2020 04:50PM UTC

Files 29

Run time 3s

Badge

Embed ▾

Committed 18 Sep 2020 04:31PM UTC coverage: 99.519% (-0.5%) from 99.99%

Job # 1962.4

Build Type

push

travis-pro

Committed by

web-flow

Commit Message

Use Error subclasses instead of functions. (#590)

I believe this has several advantage:

  1) reading the code it is obvious we are directly raising instead of
  doing more stuff.

  2) in traceback the last frame will be correct, so it's easier to find
  where the error occurs.

  3) All of these are now subclasses which can be caught independently
  by libraries while still being subclass of ValueError, so backward
  compatible. Can be caught without catching other ValueErrors.

  4) the name of the class is descriptive

I'm not too sure about some naming. Is ContainsXxxxError sufficient to
understand that it contain Xxxxx but Xxxx was not expected ?

Run Details

9931 of 9979 relevant lines covered (99.52%)

1.0 hits per line

zarr-developers / zarr-python / 1962 / 4
100%
master: 100%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 1962.4

zarr-developers / zarr-python / 1962 / 4 100% master: 100%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 1962.4

zarr-developers / zarr-python / 1962 / 4
100%
master: 100%

README BADGES
x