gnosis / dex-services / 5082 / 3

31%

master: 31%

push

travis-pro

New best ask and bid API for Pricegraph (#1400)

This PR adds new methods for computing best ask and bid orders for a market instead of relying on special values (it used to require estimating a price with a `0.0` max sell amount).

### Test Plan

Added new unit test to check price estimates with invalid sell amounts, also make sure that the the `estimated-best-ask-price` endpoint returns prices in quote:
```
$ curl -s 'http://localhost:8080/api/v1/markets/1-7/estimated-best-ask-price' | jq
362.56585811394814
```

Which makes sense given that the current price of ETH is ~350$ and the quote token is DAI.

12916 of 52940 branches covered (24.4%)

Branch coverage included in aggregate %.

3425 of 5358 relevant lines covered (63.92%)

44179.76 hits per line