7
66%
master: 66%

Ran 31 Aug 2020 06:52PM UTC

Files 113

Run time 7s

Badge

Embed ▾

Committed 31 Aug 2020 06:47PM UTC coverage: 65.887% (-0.008%) from 65.895%

Job # RUN="coverage" CONTAINER="netaccess"

Build Type

push

travis-pro

Committed by

web-flow

Commit Message

core: Remove nil checks for core proto types. (#5062)

In preparation for moving to proto3 for the core/proto types
(Registration, Order, Authorization, Challenge, etc), this removes
checks that will fail when a proto2 client or server receives a message
from a proto3 client or server. Since proto3 encodes fields that have
their zero value as being absent (i.e. nil, in Go), we treat nil the
same as having a zero value.

In the process this change introduces additional checks, verifying
certain fields which should never have a zero value.

This involves factoring out registrationValid into registrationValid and
newRegistrationValid, since new registration requests lack some fields that
already-created registrations should always have.

Similarly, UpdateRegistration is changed to not verify that
`request.Update` is valid, since an update to registration object is not
a complete registration object - it may only update one field.

Run Details

13290 of 20171 relevant lines covered (65.89%)

0.74 hits per line

letsencrypt / boulder / 12929 / 7
66%
master: 66%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 12929.7 (RUN="coverage" CONTAINER="netaccess")

letsencrypt / boulder / 12929 / 7 66% master: 66%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 12929.7 (RUN="coverage" CONTAINER="netaccess")

letsencrypt / boulder / 12929 / 7
66%
master: 66%

README BADGES
x