2
87%
master: 87%

Ran 26 Aug 2020 10:09PM UTC

Files 28

Run time 1s

Badge

Embed ▾

Committed 26 Aug 2020 10:09PM UTC coverage: 86.802%. First build

Job # GIMME_GO_VERSION=1.13.x GIMME_OS=linux GIMME_ARCH=amd64

Build Type

push

travis-ci-com

Committed by

web-flow

Commit Message

fix: Allowed hosts middleware does not check port (#271)

Summary:

This fixes an issue with the allowed hosts middleware that could prevent legitimate requests from being served.

The middleware extracts a host value from requests to compare agains the allow-list configured in server.allowedHosts. These request host values can take two possible forms:

1. Just a host (i.e. example.com), or
2. A host + port combination, separated by : (example.com:8080).

Previously, when the request host value did contain a port (the 2nd form), and that port differed from the server.port configuration value, the middleware would reject the request.

With this change, only the host is used for comparison against the configured allow-list. If the port is present, it is ignored.

Test Plan:

- Updated unit tests
- Manually tested

Run Details

1539 of 1773 relevant lines covered (86.8%)

4.78 hits per line

optimizely / agent / 1439 / 2
87%
master: 87%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 1439.2 (GIMME_GO_VERSION=1.13.x GIMME_OS=linux GIMME_ARCH=amd64)

optimizely / agent / 1439 / 2 87% master: 87%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 1439.2 (GIMME_GO_VERSION=1.13.x GIMME_OS=linux GIMME_ARCH=amd64)

optimizely / agent / 1439 / 2
87%
master: 87%

README BADGES
x