3
95%
master: 95%

Ran 22 Aug 2020 07:53PM UTC

Files 3

Run time 53s

Badge

Embed ▾

Committed 22 Aug 2020 07:51PM UTC coverage: 87.574% (+0.1%) from 87.445%

Job # COVERALLS_PARALLEL=true TOXENV=py36

Build Type

push

travis-ci-com

Committed by

web-flow

Commit Message

Correctly match package/module names in import hook (#144)

The previously used regular expression tried to handle both exact
matches and and prefix matches in one go, using this approach:

    re.compile(r'^%s\.?' % pkg)

However, this is incorrect, since the literal dot is optional in the
pattern, causing longer matches to also get included. For example, ‘foo’
should match ‘foo’ and ‘foo.bar’, but it also incorrectly matches
‘foobar’:

    >>> re.compile(r'^foo\.?').match('foobar')
    <_sre.SRE_Match object; span=(0, 3), match='foo'>

In practice, a command like this (using the pytest plugin as an example)
is supposed to check the ‘flask’ package and any modules below it:

    pytest --typeguard-packages=flask

... but in reality it also checks other packages, such as
‘flask_sqlalchemy’ and ‘flask_redis’, if those happen to be installed.

This can be easily fixed by not using regular expression, but simple
string matching instead.

Coverage Stats

592 of 676 relevant lines covered (87.57%)

0.88 hits per line

agronholm / typeguard / 262 / 3
95%
master: 95%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 262.3 (COVERALLS_PARALLEL=true TOXENV=py36)

agronholm / typeguard / 262 / 3 95% master: 95%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 262.3 (COVERALLS_PARALLEL=true TOXENV=py36)

agronholm / typeguard / 262 / 3
95%
master: 95%

README BADGES
x