13
66%
master: 66%

Ran 18 Aug 2020 11:38PM UTC

Files 113

Run time 5s

Badge

Embed ▾

Committed 18 Aug 2020 11:20PM UTC coverage: 66.033% (+0.07%) from 65.965%

Job # RUN="coverage" CONTAINER="netaccess"

Build Type

push

travis-pro

Committed by

web-flow

Commit Message

sa: remove nil checks for zero-able fields. (#5034)

As part of the migration to proto3, any fields in requests that may be
zero should also be allowed to be nil. That's because proto3 will
represent those fields as absent when they have their zero value.

This is based on a manual review of the wrappers for the SA, plus
a pair of integration test runs. For the integration test runs I took these
steps:

1. Copy sa/proto to sa/proto2
2. Change sa/proto to use proto3 and regenerate.
3. In sa/*.go and cmd/boulder-sa/main.go, update the imports to use the
    proto2 version.
4. Split grpc/sa-wrappers.go into sa-server-wrappers.go and sa-wrappers.go
    (containing the client code)
5. In sa-server-wrappers.go, change the import to use sa/proto2.
6. In sa-server-wrappers.go, make a local copy of the core.StorageAuthority
    interface that uses the sa/proto2 types. This was necessary as
    a temporary kludge because of how the server wrapper internally
    uses the core.StorageAuthority interface.
7. Fix all the pointer-vs-value build errors in every other package.
8. Run integration tests.

I also performed those steps with proto2 and proto3 swapped, to confirm the
behavior when a proto2 client talks to a proto3 SA.

Run Details

13330 of 20187 relevant lines covered (66.03%)

0.74 hits per line

letsencrypt / boulder / 12869 / 13
66%
master: 66%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 12869.13 (RUN="coverage" CONTAINER="netaccess")

letsencrypt / boulder / 12869 / 13 66% master: 66%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 12869.13 (RUN="coverage" CONTAINER="netaccess")

letsencrypt / boulder / 12869 / 13
66%
master: 66%

README BADGES
x