1
72%
master: 72%

Ran 02 Aug 2020 04:03PM UTC

Files 546

Run time 28s

Badge

Embed ▾

Committed 02 Aug 2020 04:03PM UTC coverage: 71.72% (+0.005%) from 71.715%

Job # 893.1

Build Type

push

jenkins

Committed by GitHub

Commit Message

Track ZooKeeper errors as causes of ZKException

Descriptions of the changes in this PR:

### Motivation

Every time a problem with ZK arises you don't see it in the exception chain of the BKException (in this case ZKException) and you end up with errors like:
```
org.apache.bookkeeper.client.BKException$ZKException: Error while using ZooKeeper
        at org.apache.bookkeeper.client.SyncCallbackUtils.finish(SyncCallbackUtils.java:83)
        at org.apache.bookkeeper.client.SyncCallbackUtils$SyncAddCallback.addComplete(SyncCallbackUtils.java:251)
        at org.apache.bookkeeper.client.AsyncCallback$AddCallback.addCompleteWithLatency(AsyncCallback.java:91)
        at org.apache.bookkeeper.client.PendingAddOp.submitCallback(PendingAddOp.java:430)
        at org.apache.bookkeeper.client.LedgerHandle.errorOutPendingAdds(LedgerHandle.java:1784)
        at org.apache.bookkeeper.client.LedgerHandle$5.safeRun(LedgerHandle.java:574)
```

### Changes
Add a "cause" to every ZKException.

### Notes
There are very few places that cannot be fixed because they are still using the old callback based mechanism without CompletableFuture. Those points are not changed in order to make the patch simple but still useful.





Reviewers: Jia Zhai <zhaijia@apache.org>

This closes #2384 from eolivelli/fix/zkexception-chain

Run Details

28579 of 39848 relevant lines covered (71.72%)

0.72 hits per line

apache / bookkeeper / 893 / 1
72%
master: 72%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 893.1

apache / bookkeeper / 893 / 1 72% master: 72%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 893.1

apache / bookkeeper / 893 / 1
72%
master: 72%

README BADGES
x