14
66%
master: 66%

Ran 20 Jul 2020 06:28PM UTC

Files 111

Run time 26s

Badge

Embed ▾

Committed 20 Jul 2020 06:12PM UTC coverage: 65.678% (-0.06%) from 65.741%

Job # RUN="coverage" CONTAINER="netaccess"

Build Type

push

travis-pro

Committed by

web-flow

Commit Message

Simplify database interactions (#4949)

Simplify database interactions

This change is a result of an audit of all places where
Go code directly constructs SQL queries and executes them
against a dbMap, with the goal of eliminating all instances
of constructing a well-known object type (such as a
core.CertificateStatus) from explicitly-listed database columns.
Instead, we should be relying on helper functions defined in the
sa itself to determine which columns are relevant for the
construction of any given object.

This audit did not find many places where this was occurring. It
did reveal a few simplifications, which are contained in this
change:
1) Greater use of existing SelectFoo methods provided by models.go
2) Streamlining of various SelectSingularFoo methods to always
   select by serial string, rather than user-provided WHERE clause
3) One spot (in ocsp-responder) where using a well-known type seemed
   better than using a more minimal custom type

Addresses #4899

Run Details

13014 of 19815 relevant lines covered (65.68%)

0.74 hits per line

letsencrypt / boulder / 12575 / 14
66%
master: 66%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 12575.14 (RUN="coverage" CONTAINER="netaccess")

letsencrypt / boulder / 12575 / 14 66% master: 66%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 12575.14 (RUN="coverage" CONTAINER="netaccess")

letsencrypt / boulder / 12575 / 14
66%
master: 66%

README BADGES
x