share / sharedb / 1440 / 2

97%

master: 97%

Build Type

push

travis-ci

Committed by Alec Gibson

Commit Message

<a href="https://github.com/share/sharedb/commit/<a class=hub.com/share/sharedb/commit/bd1138ff97db44191a259c2d432e04f3d7bf8a23">bd1138ff9<a href="https://github.com/share/sharedb/commit/bd1138ff97db44191a259c2d432e04f3d7bf8a23">&quot;&gt;Ignore doc does not exist on presence destroy

When we destroy local presence, we attempt to update the presence to
`null` for remote clients as part of the cleanup.

However, if we delete a doc, and then destroy the associated presence,
the presence attempts to send a message on a deleted doc, which returns
an error.

Let&amp;#39;s just ignore this error. There&amp;#39;s no need to reset presence on a
deleted doc, because remote clients will [already assume it&amp;#39;s `null`][1].

[1]: https://github.com/share/sharedb/blob/</a><a class="double-link" href="https://github.com/share/sharedb/commit/<a class="double-link" href="https://github.com/share/sharedb/commit/a81e2c99af77da12885f0fa860e87cc2602a6cc1">a81e2c99a</a>">a81e2c99a</a><a href="https://github.com/share/sharedb/commit/bd1138ff97db44191a259c2d432e04f3d7bf8a23">/lib/client/presence/local-doc-presence.js#L90-L96

Run Details

1427 of 1652 branches covered (86.38%)

3096 of 3180 relevant lines covered (97.36%)

181.58 hits per line