1
45%
master: 45%

Ran 08 Jul 2020 06:25PM UTC

Files 17

Run time 51s

Badge

Embed ▾

Committed 08 Jul 2020 06:23PM UTC coverage: 39.244% (+0.1%) from 39.126%

Job # 253.1

Build Type

push

travis-ci

Committed by

stephen

Commit Message

executor: check context cancellation before invalidation

We noticed an issue with short-lived KeepAlive tasks where the invalidation
plan would be attempted after shutdown had already started. To prevent that from
panicking during shutdown (we'd try to publish events on a closed event channel),
we check context cancellation here before running any invalidation.

In general, the concurrency story in the executor feels pretty fragile - we may consider
re-examining this code in more detail later. I want to ship this change as a stop-gap
in the meantime.

Run Details

405 of 1032 relevant lines covered (39.24%)

2.78 hits per line

samsarahq / taskrunner / 253 / 1
45%
master: 45%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 253.1

samsarahq / taskrunner / 253 / 1 45% master: 45%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 253.1

samsarahq / taskrunner / 253 / 1
45%
master: 45%

README BADGES
x