pywbem / pywbemtools / 3758 / 5
93%
master: 93%

DEFAULT BRANCH: master
Ran
Files 19
Run time 44s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 90.723% (-0.02%) from 90.746%
PACKAGE_LEVEL=latest

push

travis-ci

web-flow 
Fixes #596: Location of connection file (#659)

* Fixes Issue # 596 - Location of connection file

Allows connection file to be in either users home directory (default)
or directory/filename defined by new parameter --connections-file

The code in ConnectionRepository was refactored to:

1. Eliminate the class attributes for the repository dictionary and
make the whole class based on the class instance. Thus the Connection
Repository is instantiated only once in an interactive session.
This meant

  a. Added the created ConnectionRepository instance to the context_obj
  b. References the contextObj.connections_repo rather than constructing a new
     ConnectionRepository each time a command uses the repository
  c. Make the ConnectionRepository lazy load the YAML file
     so that a new repository can be created without getting
     caught in the issue of the code not existing.  Each
     read connection repository read access  method attempts to
     load the repository so that the repository is loaded only
     the first time it is used.
  d. Changed some variables naming in pywbemcli when the new
     general options --connection-file was added. In particular
     changed internal name of svr_name to connections_name
     internally but kept same name on option.
  d. Specifically test for existence of a connections_file in
     a number of the connection command group commands.

2. Add a new general option (--connections-file) that allows the
   user to specifically define the connections file.

3. Move the whole decision process for the name of the file into
   pywbemcli before the instance of ContextObj is created so that
   it is the ConnectionRepository object that is maintained in
   ContextObj.

4. Extended and corrected some tests to account for the new
   functionality.

* Fixes from comments and last review

1. Fixed some text in commands.rst

2. Fixed per comment in generaoptions.rst

3. Added ... (continued)

2973 of 3277 relevant lines covered (90.72%)

0.91 hits per line

Source Files on job 3758.5 (PACKAGE_LEVEL=latest)