7
66%
master: 66%

Ran 06 Jul 2020 05:17PM UTC

Files 110

Run time 1min

Badge

Embed ▾

Committed 06 Jul 2020 05:06PM UTC coverage: 66.301% (+0.002%) from 66.299%

Job # RUN="coverage" CONTAINER="netaccess"

Build Type

push

travis-pro

Committed by

web-flow

Commit Message

Fix error types emitted by good_key.go (#4932)

The `KeyPolicy.GoodKey` method is used to validate both public keys
used to sign JWK messages, and public keys contained inside CSR
messages.

According to RFC8555 section 6.7, validation failure in the former
case should result in `badPublicKey`, while validation failure in
the latter case should result in `badCSR`. In either case, a failure
due to reasons other than the key itself should result in
`serverInternal`.

However, the GoodKey method returns a variety of different errors
which are not all applicable depending on the context in which it is
called. In addition, the `csr.VerifyCSR` method passes these errors
through verbatim, resulting in ACME clients receiving confusing and
incorrect error message types.

This change causes the GoodKey method to always return either a
generic error or a KeyError. Calling methods should treat a `KeyError`
as either a `badPublicKey` or a `badCSR` depending on their context,
and may treat a generic error however they choose (though likely as a
serverInternal error).

Fixes #4930

Run Details

12993 of 19597 relevant lines covered (66.3%)

0.74 hits per line

letsencrypt / boulder / 12498 / 7
66%
master: 66%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 12498.7 (RUN="coverage" CONTAINER="netaccess")

letsencrypt / boulder / 12498 / 7 66% master: 66%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 12498.7 (RUN="coverage" CONTAINER="netaccess")

letsencrypt / boulder / 12498 / 7
66%
master: 66%

README BADGES
x