JuliaFolds / InitialValues.jl / 248 / 4

90%

master: 90%

push

travis-ci-com

<a href="https://github.com/JuliaFolds/InitialValues.jl/commit/<a class=hub.com/JuliaFolds/InitialValues.jl/commit/3fc7112a98ea476d74e76863a22386f828ff304a">3fc7112a9<a href="https://github.com/JuliaFolds/InitialValues.jl/commit/3fc7112a98ea476d74e76863a22386f828ff304a">&quot;&gt;Deprecate `Init(op)` (#47)

Using `foldl(op, xf, collection; init = Init)` in Transducers.jl has
been very useful.  However, it requires a special handling of `Init`
because it is not in the &amp;quot;initializer&amp;quot; type hierarchy:

&amp;gt; ```julia
&amp;gt; initialize(::typeof(Init), op) = check_init(Init(op), Init, op)
&amp;gt; initialize(f::InitOf, op) = check_init(f(op), f, op)
&amp;gt; ```
&amp;gt; --- https://github.com/JuliaFolds/Transducers.jl/blob/</a><a class="double-link" href="https://github.com/JuliaFolds/InitialValues.jl/commit/<a class="double-link" href="https://github.com/JuliaFolds/InitialValues.jl/commit/e5bc17538f16a0cc2d89e128bc509b8b1efa6bfc">e5bc17538</a>">e5bc17538</a><a href="https://github.com/JuliaFolds/InitialValues.jl/commit/3fc7112a98ea476d74e76863a22386f828ff304a">/src/core.jl#L873-L874

A (failed) solution attempted was to move the initializer API to
InitialValues.jl:

https://github.com/JuliaFolds/InitialValues.jl/pull/35

However, it didn&#39;t work well because the initializer is tightly
coupled with `Transducers.start` API.  It looks like moving this to
Transducers.jl (or &quot;FoldsBase.jl&quot;) would be better:

* https://github.com/JuliaFolds/InitialValues.jl/pull/37: revert #35
* https://github.com/JuliaFolds/Transducers.jl/pull/289#issuecomment-633291202:
Explains the rationale to revert #35.

In order to treat `Init` in a unified &quot;initializer&quot; framework while
keeping InitialValues.jl self-contained, this PR starts the process of
removing `Init` from InitialValues.jl by deprecating it.  The new
interface is simply `InitialValue(op)`.  This is nice also because
`InitialValue(op) isa InitialValue` holds.

See also:
https://github.com/JuliaFolds/Transducers.jl/pull/341
(Refactoring initializer API; define `Init` in Transducers.jl)

50 of 55 relevant lines covered (90.91%)

13.55 hits per line