1
94%
master: 96%

Ran 30 Jun 2020 04:47PM UTC

Files 8

Run time 8min

Badge

Embed ▾

Committed 30 Jun 2020 04:41PM UTC coverage: 94.0%. First build

Job # 252.1

Build Type

push

travis-ci

Committed by

chriswmackey

Commit Message

fix(model): Remove global_construction_set key from Model properties

This commit removes the `global_construction_set` key on the Model object and gets rid of the corresponding bugs they create.

The aim is that the default objects typically expressed in this global set are now constant across all machines, plugins and libraries now that they live in their own JSON files that all developers can load from [here](https://github.com/ladybug-tools/honeybee-standards/blob/master/honeybee_standards/energy_default.json).  This will ensure that everyone is in agreement about these defaults across plugins without the need to repeat them in the schema of individual models.

So now, if users want to override the default Constructions/Modifiers, the recommendation is to do them with a ConstructionSet or ModifierSet object applied to a Dragonfly Room2D, Story or Building.

CC: @MingboPeng , @ksobon, @theo-armour

Run Details

188 of 200 relevant lines covered (94.0%)

0.94 hits per line

ladybug-tools / dragonfly-schema / 252 / 1
94%
master: 96%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 252.1

ladybug-tools / dragonfly-schema / 252 / 1 94% master: 96%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 252.1

ladybug-tools / dragonfly-schema / 252 / 1
94%
master: 96%

README BADGES
x