7
50%
master: 49%

Ran 25 Jun 2020 11:14PM UTC

Files 109

Run time 13s

Badge

Embed ▾

Committed 25 Jun 2020 11:14PM UTC coverage: 49.984%. First build

Job # TOXENV=py37-cov-travis

Build Type

push

travis-ci

Committed by

rohanpm

Commit Message

Fix middleware TypeError where ImproperlyConfigured was expected

"getattr(settings, var, [])" is not a valid way of defaulting
any empty value into an empty list. If the value is present but
None, it will evaluate to None, which then crashes due to
attempting to evaluate "value not in None". Rewrite it to tolerate
values which are present but None.

Additionally, using hasattr together with a call to getattr
providing a default value is pointless, so it was dropped.
The default value in getattr only applies if the object doesn't
have the attribute, in which case we can't possibly have passed
the hasattr check, so the former default of [] was never used.

In practice, this would happen with MIDDLEWARE on some versions
of Django, which globally defaults to None. This was a low impact
bug, since it only converted one type of crash into another.

Run Details

3059 of 6120 relevant lines covered (49.98%)

0.5 hits per line

rohanpm / kobo / 25 / 7
50%
master: 49%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 25.7 (TOXENV=py37-cov-travis)

rohanpm / kobo / 25 / 7 50% master: 49%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 25.7 (TOXENV=py37-cov-travis)

rohanpm / kobo / 25 / 7
50%
master: 49%

README BADGES
x