qunitjs / qunit / 2599 / 8

89%

main: 90%

push

travis-ci-com

<a href="https://github.com/qunitjs/qunit/commit/<a class=hub.com/qunitjs/qunit/commit/91b69958f71dd6cd96fdeec6573199c1cfec4530">91b69958f<a href="https://github.com/qunitjs/qunit/commit/91b69958f71dd6cd96fdeec6573199c1cfec4530">&quot;&gt;All: Update node-watch dependency and test fixtures for Node 12+

== Test fixtures ==

Node 6-10:
&amp;gt; at process._tickCallback (internal/process/next_tick.js…)
&amp;gt; at ontimeout (timers.js…)

Node 12-14:
&amp;gt; at processTicksAndRejections (internal/process/task_queues.js…)
&amp;gt; at listOnTimeout (internal/timers.js…)

== Test memory ==

Also update the memory-leak test to use a different strategy
because the V8 native `%GetWeakSetValues` function no longer
exists as of V8 7.1 (or 8.1, not sure) per
&amp;lt;https://chromium.googlesource.com/v8/v8/+/</a><a class="double-link" href="https://github.com/qunitjs/qunit/commit/<a class="double-link" href="https://github.com/qunitjs/qunit/commit/0cf4a0f82f8f810519ba0d4b3b01adef0a0a6c1d">0cf4a0f82</a>">0cf4a0f82</a><a href="https://github.com/qunitjs/qunit/commit/91b69958f71dd6cd96fdeec6573199c1cfec4530">&gt;
&lt;https://chromium-review.googlesource.com/c/v8/v8/+/1238574&gt;.

Instead, inspect a heap snapshot and validate it that way.
Also expand the test so that we first verify our logic actually
works, for easier debugging in the future.

== Recursive watch ==

As of Node 14, `fs.watch` can throw ERR_FEATURE_UNAVAILABLE_ON_PLATFORM,
which is handled by node-watch 0.6.4 per
&lt;https://github.com/yuanchuan/node-watch/commit/fd5d4655ca47db56&gt;.

Without this, Node 14 fails as follows:

&gt; CLI Watch &gt; runs tests and waits until SIGTERM
&gt;
&gt; TypeError [ERR_FEATURE_UNAVAILABLE_ON_PLATFORM]:
&gt; The feature watch recursively is unavailable on the current platform, …
&gt; at Object.watch (fs.js)
&gt; at hasNativeRecursive (…/node_modules/node-watch/lib/has-native-recursive.js)
&gt; at Watcher.watchDirectory (…/node_modules/node-watch/lib/watch.js)
&gt; at watch (…/node_modules/node-watch/lib/watch.js)
&gt; at Function.watch (qunitjs/qunit/src/cli/run.js)

Fixes https://github.com/qunitjs/qunit/issues/1430.
Closes https://github.com/qunitjs/qunit/pull/1448.

901 of 1910 branches covered (47.17%)

1693 of 3052 relevant lines covered (55.47%)

151.07 hits per line