SAP / fundamental-ngx / 9169 / 1

79%

master: 79%

push

travis-ci

fix: combobox click autocomplete (#2447)

* start on combobox click improvements

* more combobox behavior improvements

* more combobox progress

* more tests

* autocomplete now working

* fix bug where pressing enter twice changes selection

* autocomplete should not be case sensitive

* fix bug where replacing text with shorter string would not autocomplete

* more tests

* pr comments

* cleaner code for adding/removing is-expanded class

* component structure guideline

* fix autocomplete for display object property

* fix autocomplete for combobox with groups

* behavior subject selected works for basic string array but not custom objects, grouped objects, etc

* more improvements to combobox filter and selection logic

* backspace/delete bug, enter not closing list bug

* start going through new pr comments

* more pr comments

* code cleanup/comments/bug fixes

* add KeyUtil to combobox

* missed a few event.key and also fix tests

* no more oldInputText - everything needs to be keydown

* move some stuff in to private methods

* fix most github PR comments

* address remaining PR comments

* fix test

* fix examples, remove inShellbar from api docs

* comment

* no more inShellbar input

* fix popover reopen on enter, up/down arrow selection, fix import

* add input text change event, fix test

* force build

* input enter keyup bug

* fix custom filter example index

* itemClicked event should pass index from dropdownValues not displayedValues

* Fix arrowDown/arrowUp

* Add auto complete directive, change examples

* Add auto complete tests

* fix tests, remove leftovers

* small combobox tweaks

* Add prevention from crtl/cmd + a

* add Meta key as an alias of Ctrl for mac users

* blur event fix

* fix minor code styling

* Fix blur effect, fix examples

* remove unused code from examples

* move cursor to end on blur

Co-authored-by: Jedrzej ... (continued)

1647 of 2491 branches covered (66.12%)

Branch coverage included in aggregate %.

5711 of 6592 relevant lines covered (86.64%)

85.3 hits per line