2
88%
develop: 37%

Ran 04 Jun 2015 01:05PM UTC

Files 116

Run time 15min

Badge

Embed ▾

Committed 04 Jun 2015 01:05PM UTC coverage: 88.05%. First build

Job # 1.9.3

Build Type

Pull #2505

travis-ci

Committed by Gareth Rees

Commit Message

Avoid loading associations to check existence

Calling InfoRequestEvent#is_X? loads the associated model from the
database. We don't need to do this to check what 'type' the event is.

This commit first checks whether there is an association_id – if there
is then we know it's that 'type'. If there's no association_id, call the
association to check whether one has been added but not yet persisted.

Only check association if the object is a new record. This avoids
checking the association on a persisted record when we know it isn't
that type of event due to the database record not existing.

Pull Request Pull Request #2505:

Run Details

6145 of 6979 relevant lines covered (88.05%)

169.08 hits per line

mysociety / alaveteli / 2573 / 2
88%
develop: 37%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 2573.2 (1.9.3)

mysociety / alaveteli / 2573 / 2 88% develop: 37%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 2573.2 (1.9.3)

mysociety / alaveteli / 2573 / 2
88%
develop: 37%

README BADGES
x