9
85%
main: 91%

Ran 08 Jun 2020 09:36PM UTC

Files 56

Run time 4s

Badge

Committed 08 Jun 2020 07:43PM UTC coverage: 84.779%. First build

Job # CHANGE_MINIKUBE_NONE_USER=true KUBECONFIG=$HOME/.kube/config MINIKUBE_WANTUPDATENOTIFICATION=false MINIKUBE_WANTREPORTERRORPROMPT=false MINIKUBE_IN_STYLE=true MINIKUBE_HOME=$HOME MINIKUBE_VERSION=latest KUBERNETES_VERSION=latest CLIENT=yes

Build Type

push

travis-ci

Committed by

nolar

Commit Message

Secure the log strings from injections and for better template-matching

Generally, we can trust the codebase of the operators, as only
the code owners can inject arbitrary handler ids or task names.
But in case they are dynamic and use the data from the CR-users,
this can lead to log template injections and cause errors of DoS
(mostly when at least some positional args are passed to loggers).

We can make it a bit more secure by not using any f-strings
in the log message templates, unless the variables come strictly
from Kopf, not even from the Kopf-based operators.

This also improves the template-matching: the logging handlers
and formatters get the template strings with %s/%r instead of
actual variable values which differ every time, so they report
these messages by their proper templates (e.g. in Sentry).

Run Details

1031 of 1287 branches covered (80.11%)

Branch coverage included in aggregate %.

3319 of 3844 relevant lines covered (86.34%)

0.86 hits per line

Source Files on job 1144.9 (CHANGE_MINIKUBE_NONE_USER=true KUBECONFIG=$HOME/.kube/config MINIKUBE_WANTUPDATENOTIFICATION=false MINIKUBE_WANTREPORTERRORPROMPT=false MINIKUBE_IN_STYLE=true MINIKUBE_HOME=$HOME MINIKUBE_VERSION=latest KUBERNETES_VERSION=latest CLIENT=yes)

nolar / kopf / 1144 / 9
85%
main: 91%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 1144.9 (CHANGE_MINIKUBE_NONE_USER=true KUBECONFIG=$HOME/.kube/config MINIKUBE_WANTUPDATENOTIFICATION=false MINIKUBE_WANTREPORTERRORPROMPT=false MINIKUBE_IN_STYLE=true MINIKUBE_HOME=$HOME MINIKUBE_VERSION=latest KUBERNETES_VERSION=latest CLIENT=yes)

nolar / kopf / 1144 / 9 85% main: 91%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 1144.9 (CHANGE_MINIKUBE_NONE_USER=true KUBECONFIG=$HOME/.kube/config MINIKUBE_WANTUPDATENOTIFICATION=false MINIKUBE_WANTREPORTERRORPROMPT=false MINIKUBE_IN_STYLE=true MINIKUBE_HOME=$HOME MINIKUBE_VERSION=latest KUBERNETES_VERSION=latest CLIENT=yes)

nolar / kopf / 1144 / 9
85%
main: 91%

README BADGES
x