apache / bookkeeper / 817 / 1
72%
master: 72%

DEFAULT BRANCH: master
Ran
Files 537
Run time 54s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 71.844% (+0.09%) from 71.758%
817.1

push

jenkins

GitHub 
[BOOKIE-MTLS] add support of hostname verification

### Motivation

Right now, bookkeeper-client is not able to perform [hostname-verification](https://tersesystems.com/blog/2014/03/23/fixing-hostname-verification/) when it connects to broker over tls. Hostname-verification feature is already implemented in almost all [http-client](https://github.com/apache/httpcomponents-client/blob/master/httpclient5/src/main/java/org/apache/hc/client5/http/ssl/DefaultHostnameVerifier.java) but it's not supported by [netty](https://stackoverflow.com/questions/13315623/netty-ssl-hostname-verification-support) yet. therefore, client should be able to perform hostname-verification as per [RFC-2181](https://tools.ietf.org/html/rfc2818#section-3.1)

### Modifications

- added client configuration to enable hostname-verification (default disable)
- use [http-client](https://github.com/apache/httpcomponents-client/blob/master/httpclient5/src/main/java/org/apache/hc/client5/http/ssl/DefaultHostnameVerifier.java) but it's not supported by [netty](https://stackoverflow.com/questions/13315623/netty-ssl-hostname-verification-support) to perform hostname-validation rather adding custom logic.
- add httpclient-apache dependency into LICENSE and NOTICE files.

### Result

Bookkeeper client will be able to perform hostname verification while creating ssl session with bookie.

Reviewers: Enrico Olivelli <eolivelli@gmail.com>

This closes #2156 from rdhabalia/hostname

28298 of 39388 relevant lines covered (71.84%)

0.72 hits per line

Source Files on job 817.1