CohenLabPrinceton / Ventilator-Dev / 185 / 1
78%
master: 78%

DEFAULT BRANCH: master
Ran
Files 28
Run time 2s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 64.118% (+32.8%) from 31.35%
185.1

push

travis-ci-com

web-flow 
Gui integration and checkpoint (#48)

the main thing this PR does is integrate the GUI with the rest of the program. hooray!!! It also tries to bring the objects into a uniform system of naming, hooray!!!

For the most part you can skip over the docs and gui changes, as those are either benign or p esoteric stuff for the gui, but feel free to review away. I comment on general changes here and i'll go through and comment on finer-grained changes in the pr

travis & pytest

 -   add commands to set up xvfb to test gui

docs

-    generic cleanup& removal of dead references
 -   mock pigpio

tests

-    cleaned up lots of inconsistent value names, brought in line with using values.ValueName in test_controller and test_coordinator
-    added timeouts to potentially infinite tests
-    added first round of gui tests! including "run the whole thing!" and "test the small components!" don't judge my lack of tests i'm learning and trying to get there asap!!!

message

-    implementing message.SensorValues as a carrier class for sensor values. Can't use enum values as attribute names, so using the string representation of the names. to_dict restores dict of ValueName: value pairs.
-    made AlarmSeverity enum have explicit numbering so can do comparisons
-    gave Alarms unique alarm id number with itertools.counter
-    added value field to Alarm so we know how far the reading went out of bounds.

values

-    added ValueName.IE_RATIO
 -   tweaked some defaults, still have yet to implement final values from meeting
-    moved PLOTS to gui

control_module

-    added PEEP_TIME to controller -- i think we discussed not having this, but since it was listed in ValueName it should have a corresponding entry.
-    used ValueName rather than strings where applicable.
-    .running property to get running state

coordinator, process_manager, rpc

-    made get_sensors return SensorValues to be consistent with control_module
- ... (continued)

1560 of 2433 relevant lines covered (64.12%)

0.64 hits per line

Source Files on job 185.1