3
85%
main: 91%

Ran 09 Apr 2020 09:32PM UTC

Files 52

Run time 4s

Badge

Committed 09 Apr 2020 08:45PM UTC coverage: 83.311%. First build

Job # CHANGE_MINIKUBE_NONE_USER=true KUBECONFIG=$HOME/.kube/config MINIKUBE_WANTUPDATENOTIFICATION=false MINIKUBE_WANTREPORTERRORPROMPT=false MINIKUBE_IN_STYLE=true MINIKUBE_HOME=$HOME MINIKUBE_VERSION=latest KUBERNETES_VERSION=v1.16.0 CLIENT=no

Build Type

push

travis-ci

Committed by

nolar

Commit Message

Secure the log strings from injections and for better template-matching

Generally, we can trust the codebase of the operators, as only
the code owners can inject arbitrary handler ids or task names.
But in case they are dynamic and use the data from the CR-users,
this can lead to log template injections and cause errors of DoS
(mostly when at least some positional args are passed to loggers).

We can make it a bit more secure by not using any f-strings
in the log message templates, unless the variables come strictly
from Kopf, not even from the Kopf-based operators.

This also improves the template-matching: the logging handlers
and formatters get the template strings with %s/%r instead of
actual variable values which differ every time, so they report
these messages by their proper templates (e.g. in Sentry).

Run Details

706 of 896 branches covered (78.79%)

Branch coverage included in aggregate %.

2399 of 2831 relevant lines covered (84.74%)

0.85 hits per line

Source Files on job 1093.3 (CHANGE_MINIKUBE_NONE_USER=true KUBECONFIG=$HOME/.kube/config MINIKUBE_WANTUPDATENOTIFICATION=false MINIKUBE_WANTREPORTERRORPROMPT=false MINIKUBE_IN_STYLE=true MINIKUBE_HOME=$HOME MINIKUBE_VERSION=latest KUBERNETES_VERSION=v1.16.0 CLIENT=no)

nolar / kopf / 1093 / 3
85%
main: 91%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 1093.3 (CHANGE_MINIKUBE_NONE_USER=true KUBECONFIG=$HOME/.kube/config MINIKUBE_WANTUPDATENOTIFICATION=false MINIKUBE_WANTREPORTERRORPROMPT=false MINIKUBE_IN_STYLE=true MINIKUBE_HOME=$HOME MINIKUBE_VERSION=latest KUBERNETES_VERSION=v1.16.0 CLIENT=no)

nolar / kopf / 1093 / 3 85% main: 91%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 1093.3 (CHANGE_MINIKUBE_NONE_USER=true KUBECONFIG=$HOME/.kube/config MINIKUBE_WANTUPDATENOTIFICATION=false MINIKUBE_WANTREPORTERRORPROMPT=false MINIKUBE_IN_STYLE=true MINIKUBE_HOME=$HOME MINIKUBE_VERSION=latest KUBERNETES_VERSION=v1.16.0 CLIENT=no)

nolar / kopf / 1093 / 3
85%
main: 91%

README BADGES
x