share / sharedb / 1388 / 2

97%

master: 97%

Build Type

push

travis-ci

Committed by Alec Gibson

Commit Message

Fix `Presence._callEachOrEmit`

At the moment, there's a bug where we:

  1. Start disconnected
  2. Submit a presence subscribe request with **no callback**
  3. Connect
  4. The presence then subscribes and calls each callback, but doesn't
     check whether the callback is truthy, which throws

We could check callbacks when we first assign them to the internal map,
but it's quite nice for debugging to see an `undefined` callback
attached to a `seq`.

Therefore, we should handle callbacks not existing when actually
calling them, which `Doc` already does.

This change moves the `Doc` `callEach` method into `utils`, where we can
also use it in `Presence`.

Run Details

1405 of 1630 branches covered (86.2%)

3073 of 3157 relevant lines covered (97.34%)

178.71 hits per line