theupdateframework / tuf / 1775 / 3

98%

develop: 97%

Pull #1012

travis-ci

Improve performance of delegate_hashed_bins

Due to the performance overhead of deepcopy(), as used extensively in
roledb, the delegate function is rather slow. This is especially
noticeable when we have a large number_of_bins when calling
delegate_hashed_bins.

In order to be able to easily reduce the number of deepcopy() operations
we remove direct calls to delegate() and instead use the newly added
helper functions to replicate the behaviour, only with a single call
update to the roledb.

This improves the performance of a 16k bins delegation from a 1hr 24min
operation on my laptop to 33s.

Ideally once Issue #1005 has been properly fixed this commit can be
reverted and we can once again just call delegate() here.

Signed-off-by: Joshua Lock <jlock@vmware.com>

853 of 890 branches covered (95.84%)

3041 of 3092 relevant lines covered (98.35%)

0.98 hits per line