1
93%
master: 93%

Ran 02 Apr 2020 08:17AM UTC

Files 42

Run time 38s

Badge

Embed ▾

Committed 02 Apr 2020 08:16AM UTC coverage: 95.193% (-0.05%) from 95.245%

Job # TELNYX_MOCK_VERSION=0.8.6

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

ENGDESK-4618: Rewrite reserved words on nested resource class methods (#21)

`nested_resource_class_methods` methods use their own API requestor
instance to make the HTTP request. It was forgotten to rewrite the
reserved words before using them in this request.

When testing this change, I noticed we didn't seem to handle the
returned response at all. If the API returned an response body with
`{"from": "foo"}`, the attribute would be initialised with `obj.from =
"foo"`. This meant future updates would fail as attempting to set
`obj.from` would result in an error due to the reserved keyword. You
would have to use `setattr(obj, "from", "baz")`.

I've fixed this by ensuring reserved words are rewritten not only before
sending them to the API but also when handling the response.

This means you can now do:

    obj = BaseClass.nested_resource.create(from_="foo")
    obj.from_ = "baz"
    obj.save()

    assert obj.from_ == "baz"

Run Details

1307 of 1373 relevant lines covered (95.19%)

0.95 hits per line

team-telnyx / telnyx-python / 205 / 1
93%
master: 93%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 205.1 (TELNYX_MOCK_VERSION=0.8.6)

team-telnyx / telnyx-python / 205 / 1 93% master: 93%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 205.1 (TELNYX_MOCK_VERSION=0.8.6)

team-telnyx / telnyx-python / 205 / 1
93%
master: 93%

README BADGES
x