15
91%
master: 91%

Ran 02 Apr 2020 05:32AM UTC

Files 18

Run time 1s

Badge

Embed ▾

Committed 02 Apr 2020 05:09AM UTC coverage: 88.484%. Remained the same

Job # PKGS="python=3.8 numpy uncertainties"

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

Merge #1041

1041: Return expected empty type for parse_pattern function r=hgrecco a=abmyii

N.B. Pardon me if I didn't follow convention by opening an issue before making this PR.

Whilst using the `parse_pattern` function with `pandas` I realised the `return self.Quantity(1)` returned a dimensionless quantity which would be out of place compared to all of the other returned values causing parsing issues. The error I was getting was:
```
  File "/usr/lib/python3.6/site-packages/pandas/core/frame.py", line 1598, in from_records
    arrays, arr_columns = to_arrays(data, columns, coerce_float=coerce_float)
  File "/usr/lib/python3.6/site-packages/pandas/core/internals/construction.py", line 464, in to_arrays
    return _list_to_arrays(data, columns, coerce_float=coerce_float, dtype=dtype)
  File "/usr/lib/python3.6/site-packages/pandas/core/internals/construction.py", line 496, in _list_to_arrays
    content = list(lib.to_object_array(data).T)
  File "pandas/_libs/lib.pyx", line 2275, in pandas._libs.lib.to_object_array
  File "/usr/lib/python3.6/site-packages/pint/quantity.py", line 1693, in __len__
    return len(self._magnitude)
TypeError: object of type 'int' has no len()
```

This simple fix returns a value which conforms with the expected output type.

Co-authored-by: Abdurrahmaan Iqbal <abdurrahmaaniqbal@hotmail.com>

Run Details

3596 of 4064 relevant lines covered (88.48%)

0.88 hits per line

hgrecco / pint / 1706 / 15
91%
master: 91%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 1706.15 (PKGS="python=3.8 numpy uncertainties")

hgrecco / pint / 1706 / 15 91% master: 91%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 1706.15 (PKGS="python=3.8 numpy uncertainties")

hgrecco / pint / 1706 / 15
91%
master: 91%

README BADGES
x