share / sharedb / 1379 / 1

97%

master: 97%

Build Type

push

travis-ci

Committed by Alec Gibson

Commit Message

Fix presence re-subscribe after destroy

This change fixes the following edge case:

  1. Create a `Presence` object
  2. Subscribe the presence
  3. Destroy the presence
  4. Create a new `Presence` object for the same channel on the same
     `Connection` object
  5. Attempt to re-subscribe
  6. `Agent` ignores the re-subscribe request, because the `seq` was
     reset to `1` on the new `Presence` object, but is still `2` on the
     `Agent`

We fix this by using a universal `_presenceSeq` counter on the
`Connection`, which is never reset, meaning that all presence messages
will have a strictly higher number than one another.

Run Details

1407 of 1632 branches covered (86.21%)

3075 of 3159 relevant lines covered (97.34%)

178.4 hits per line