wikimedia
/
parsoid
/
407
/
3
85%
master: 85%
master: 85%
|
Ran
|
Files
69
|
Run time
5s
|
Badge
Embed ▾
README BADGES
|
coverage: 85.29% (-0.02%) from 85.305%
push
travis-ci
subbussDon't use selser if oldid is missing * So far, we were always constructing SelectiveSerializer and checking for absence of page-src to fallback to non-selser WTS. However, that is insufficient since rt-testing provides page-src to minimize dirty diffs and we don't want to be using selser there. As per https://www.mediawiki.org/wiki/Parsoid/API#v1_API_entry_points "Both it and the oldid parameter are needed for clean round-tripping of HTML retrieved earlier with" * So much for wanting to hide internal details (of selser) from the API. This does leak selser-ability via the API, but right now, there doesn't seem to be a clean way to support all the varied use cases for html2wt that provide title, oldid, and page src. The only way to disable selser right now is to NOT provide oldid. In this patch, we'll rely on that. * Clarified the serialization properties in DOMUtils.serializeDOM to more accurately reflect when DOM/orig-src needs to be fetched -- only in selser mode. * Fixed a mocha api test to reflect this new expectation. Change-Id: I30cc1ea61
10935 of 12821 relevant lines covered (85.29%)
22387.88 hits per line
