4
85%
master: 49%

Ran 21 Mar 2020 10:16PM UTC

Files 3

Run time 0s

Badge

Embed ▾

Committed 21 Mar 2020 10:16PM UTC coverage: 84.615%. First build

Job # TEST_GROUP=3

Build Type

Pull #1570

travis-ci

Committed by Hari Shankar

Commit Message

Changing Java multiget API to return List<byte[]> instead of Map<byte[],
byte[]>. This is for two reasons:
1. Java arrays implement equals() as reference equality instead
of comparing each value. This means a HashMap should never have an array
as key, since anyone calling get() with a new array key with the exact same contents
as an existing key will get different results. It happens to work
currently because the byte[] reference is used as it is in the Map key.
But it is a confusing API for the caller becaues they cannot make this
assumption.
2. List<byte[]> keeps it close to the native API (which returns
byte[][]). It avoids the perf cost of creating a Map. If a caller does
not need Map functionality, the API should not force it unnecessarily,
especially in perf-critical use cases.

Ideally, the existing method should be deprecated and the new one added.
But that would require creating a new method name. multiGet is the best
name for this method. So I am trying to avoid changing it. This should
be a simple change for the clients to make, so as long as the major version
is bumped up, it should be ok to break backwards compatibility.

Pull Request Pull Request #1570: Changing Java multiGet API to return List<byte[]> instead of Map<byte[], byte[]>

Run Details

22 of 26 relevant lines covered (84.62%)

0.85 hits per line

facebook / rocksdb / 9819 / 4
85%
master: 49%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 9819.4 (TEST_GROUP=3)

facebook / rocksdb / 9819 / 4 85% master: 49%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 9819.4 (TEST_GROUP=3)

facebook / rocksdb / 9819 / 4
85%
master: 49%

README BADGES
x