3
86%
master: 86%

Ran 12 Mar 2020 10:26AM UTC

Files 356

Run time 47s

Badge

Embed ▾

Committed 12 Mar 2020 10:18AM UTC coverage: 85.942% (-0.005%) from 85.947%

Job # COVERAGE=true

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

[TestNG] Fix concurrent modification of events (#1919)

When a TestNG suite with `parallel="methods"` is executed TestNG will invoke
all `@DataProvider` annotated methods. Because these data providers also emit
the `TestRunStarted` event this event is emitted twice concurrently. These
events collide in the `CanonicalOrderEventPublisher` resulting in a concurrent
modification that inserts a null element rather then either of the events.

By moving the start of the test execution to the constructor we ensure that
test execution is always started serially. Additionally this ensures that it is
impossible to emit a `TestRunFinished` event without also emitting a
`TestRunStarted` event.

This comes at the cost of starting the execution as soon as the `@BeforeClass`
method is invoked. This will result in some apparent overhead as `TestNG` is
still preparing for execution.

Fixes: https://github.com/cucumber/cucumber-jvm/issues/1917

Run Details

6584 of 7661 relevant lines covered (85.94%)

0.86 hits per line

cucumber / cucumber-jvm / 3883 / 3
86%
master: 86%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 3883.3 (COVERAGE=true)

cucumber / cucumber-jvm / 3883 / 3 86% master: 86%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 3883.3 (COVERAGE=true)

cucumber / cucumber-jvm / 3883 / 3
86%
master: 86%

README BADGES
x