2
21%
master: 21%

Ran 03 Mar 2020 11:26PM UTC

Files 72

Run time 11s

Badge

Embed ▾

Committed 03 Mar 2020 11:05PM UTC coverage: 20.679% (+6.8%) from 13.83%

Job # 367.2

Build Type

push

travis-ci

Committed by

mcaskill

Commit Message

Improve dynamic route handlers

Improved logic of route handlers to return 404 responses where the model or object route is missing, 500 responses when the model is invalid (such as incomplete templating details).

Added:
- Logs (debug/warning) to various route handlers to better track when issues arise
- Checks to validate rendered template view is not empty for matches the model's template identifier
- Catch to `*Route::load*FromPath()` methods to prevent nonexistent models from breaking the runtime
- Validation/Assertion methods to `GenericRoute` to determine if the context object or current object route are valid

Changed:
- Replaced 404 status codes with 500 when the failure does not stem from a missing model
- Refactored unit tests for route handlers

Run Details

786 of 3801 relevant lines covered (20.68%)

1.34 hits per line

locomotivemtl / charcoal-cms / 367 / 2
21%
master: 21%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 367.2

locomotivemtl / charcoal-cms / 367 / 2 21% master: 21%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 367.2

locomotivemtl / charcoal-cms / 367 / 2
21%
master: 21%

README BADGES
x