zendeskgarden / react-components / 3431 / 1

97%

main: 96%

push

travis-ci

feat: add utility for menu styles (#655)

*Features*

- New `menuStyles` utility added to `react-theming` and shared between `react-datepickers` and `react-dropdowns`
- Ability to target menu wrappers with themed component custom styling

*Fixes*

- Added visibility controls (via `useEffect` with timeouts) to restore fade-out animation for both datepicker and dropdown menus –  providing subtle, important feedback that a user's action was effective
- Implemented CSS that cut out unnecessary "div soup" in dropdown menus.
  - Hiding arrow border during first phase of animation got rid of `StyledMenuAnimation` div.
  - Overriding menu positioning to `static` allows arrow to display beyond `overflow-y` and got rid of `StyledMaxHeightWrapper` div.
- Restored semantic `<ul>` - `<li>` menu structure in dropdowns.

1965 of 2096 branches covered (93.75%)

Branch coverage included in aggregate %.

5240 of 5252 relevant lines covered (99.77%)

452.74 hits per line