1
33%
master: 38%

Ran 02 Mar 2020 06:12AM UTC

Files 153

Run time 16s

Badge

Embed ▾

Committed 02 Mar 2020 06:07AM UTC coverage: 33.139%. Remained the same

Job # 2.3.8

Build Type

Pull #101

travis-ci

Committed by

web-flow

Commit Message

Explicitly enable rspec's old `should` syntax to dismiss deprecation warning

From https://relishapp.com/rspec/rspec-expectations/docs/syntax-configuration:

> We recommend you use the `expect` syntax unless you have a specific
> reason you prefer the `should` syntax. We have no plans to ever
> completely remove the `should` syntax but starting in RSpec 3, a
> deprecation warning will be issued if you do not explicitly enable
> it, with the plan to disable it by default in RSpec 4 (and
> potentially move it into an external gem).

A lot of our specs use `should`, so converting to `expect` will be a
chore. We should do it at some point, but it's not urgent so dismiss
the deprecation warning for now.

Deprecation warning dismissed:

Using `should` from rspec-expectations' old `:should` syntax without explicitly enabling the syntax is deprecated. Use the new `:expect` syntax or explicitly enable `:should` with `config.expect_with(:rspec) { |c| c.syntax = :should }` instead. Called from nztrain/spec/controllers/accounts/passwords_controller_spec.rb:10:in `block (2 levels) in <top (required)>'.

Pull Request Pull Request #101: Update RSpec from 2 to 3.9

Run Details

2325 of 7016 relevant lines covered (33.14%)

4.8 hits per line

NZOI / nztrain / 893 / 1
33%
master: 38%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 893.1 (2.3.8)

NZOI / nztrain / 893 / 1 33% master: 38%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 893.1 (2.3.8)

NZOI / nztrain / 893 / 1
33%
master: 38%

README BADGES
x