1
76%
master: 76%

Ran 24 Feb 2020 02:20PM UTC

Files 255

Run time 35s

Badge

Embed ▾

Committed 24 Feb 2020 02:03PM UTC coverage: 75.632% (+0.001%) from 75.631%

Job # 7531.1

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

Fix race condition in daemon mode between parsing and inference threads. Fixes #2201 (#2283)

Once the parsing thread detects end-of-stream for the current socket, it triggers parser.cc::reset_source,
which closes the socket and accepts a new one.

Before it does so, it waits for the example queue to be empty. Though this is a necessary condition,
it's not enough as the last example will be in flight and the inference thread can run into a closed socket
when it tries to write to it.

The fix is to keep counts of both parsed and finished examples, then wait for them to be equal before closing
the current socket.

Run Details

16065 of 21241 relevant lines covered (75.63%)

594220.31 hits per line

VowpalWabbit / vowpal_wabbit / 7531 / 1
76%
master: 76%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 7531.1

VowpalWabbit / vowpal_wabbit / 7531 / 1 76% master: 76%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 7531.1

VowpalWabbit / vowpal_wabbit / 7531 / 1
76%
master: 76%

README BADGES
x